Messages in this thread | | | Date | Mon, 4 Jan 2021 15:18:50 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net v3] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag |
| |
On Mon, Jan 04, 2021 at 10:38:02AM +0000, Charles Keepax wrote: > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > macb_set_tx_clk were gated on the presence of this flag. > > - if (!clk) > + if (!bp->tx_clk || !(bp->caps & MACB_CAPS_CLK_HW_CHG)) > > However the flag was not added to anything other than the new > sama7g5_gem, turning that function call into a no op for all other > systems. This breaks the networking on Zynq. > > The commit message adding this states: a new capability so that > macb_set_tx_clock() to not be called for IPs having this > capability > > This strongly implies that present of the flag was intended to skip > the function not absence of the flag. Update the if statement to > this effect, which repairs the existing users. > > Fixes: daafa1d33cc9 ("net: macb: add capability to not set the clock rate") > Suggested-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |