Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 4 Jan 2021 11:51:31 +0100 | Subject | Re: [PATCH] can: rcar: Update help description for CAN_RCAR_CANFD config |
| |
Hi Prabhakar,
On Thu, Dec 31, 2020 at 5:00 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > The rcar_canfd driver supports R-Car Gen3 and RZ/G2 SoC's, update the > description to reflect this. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/drivers/net/can/rcar/Kconfig > +++ b/drivers/net/can/rcar/Kconfig > @@ -10,13 +10,13 @@ config CAN_RCAR > be called rcar_can. > > config CAN_RCAR_CANFD > - tristate "Renesas R-Car CAN FD controller" > + tristate "Renesas R-Car Gen3 and RZ/G2 CAN FD controller" > depends on ARCH_RENESAS || ARM
Not introduced by this patch, but the "|| ARM" looks strange to me. Is this meant for compile-testing? Doesn't the driver compile on all platforms (it does on m68k), so "|| COMPILE_TEST" is not appropriate? Is the CAN FD controller present on some Renesas arm32 SoCs (but not yet supported by this driver)?
> help > Say Y here if you want to use CAN FD controller found on > - Renesas R-Car SoCs. The driver puts the controller in CAN FD only > - mode, which can interoperate with CAN2.0 nodes but does not support > - dedicated CAN 2.0 mode. > + Renesas R-Car Gen3 and RZ/G2 SoCs. The driver puts the > + controller in CAN FD only mode, which can interoperate with > + CAN2.0 nodes but does not support dedicated CAN 2.0 mode. > > To compile this driver as a module, choose M here: the module will > be called rcar_canfd.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |