Messages in this thread | | | Date | Tue, 22 Sep 2020 10:44:31 +0200 | From | Jan Kara <> | Subject | Re: [PATCH 03/13] bcache: inherit the optimal I/O size |
| |
On Mon 21-09-20 10:07:24, Christoph Hellwig wrote: > Inherit the optimal I/O size setting just like the readahead window, > as any reason to do larger I/O does not apply to just readahead. > > Signed-off-by: Christoph Hellwig <hch@lst.de>
The patch looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> --- > drivers/md/bcache/super.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 1bbdc410ee3c51..48113005ed86ad 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -1430,6 +1430,8 @@ static int cached_dev_init(struct cached_dev *dc, unsigned int block_size) > dc->disk.disk->queue->backing_dev_info->ra_pages = > max(dc->disk.disk->queue->backing_dev_info->ra_pages, > q->backing_dev_info->ra_pages); > + blk_queue_io_opt(dc->disk.disk->queue, > + max(queue_io_opt(dc->disk.disk->queue), queue_io_opt(q))); > > atomic_set(&dc->io_errors, 0); > dc->io_disable = false; > -- > 2.28.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |