Messages in this thread | | | Date | Thu, 10 Sep 2020 12:51:08 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] checkpatch: Warn on self-assignments |
| |
On Sat, Sep 05, 2020 at 10:58:29AM -0700, Joe Perches wrote: > The uninitialized_var() macro was removed recently via > commit 63a0895d960a ("compiler: Remove uninitialized_var() macro") > as it's not a particularly useful warning and its use can > "paper over real bugs". > > Add a checkpatch test to warn on self-assignments as a means > to avoid compiler warnings and as a back-door mechanism to > reproduce the old uninitialized_var macro behavior. > > Signed-off-by: Joe Perches <joe@perches.com>
I like it! :)
Can you add a section to code style and include a link in the checkpatch warning to it? (Feel free to just reuse the text removed from deprecated.rst)
-- Kees Cook
| |