lkml.org 
[lkml]   [2020]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH] ALSA: usb-audio: Fix memleak in scarlett2_add_new_ctl


"Takashi Iwai" <tiwai@suse.de>写道:
> On Fri, 07 Aug 2020 09:12:27 +0200,
> Dinghao Liu wrote:
> >
> > When snd_usb_mixer_add_control() fails, elem needs to be
> > freed just like when snd_ctl_new1() fails. However, current
> > code is returning directly and ends up leaking memory.
>
> No, this would lead to double-free. snd_ctl_add() shows a kind of
> special behavior, it already releases the object at its error path.
>

It's clear to me, thanks!

Regards,
Dinghao
\
 
 \ /
  Last update: 2020-08-07 11:51    [W:0.079 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site