lkml.org 
[lkml]   [2020]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 09/19] kconfig: qconf: remove unused argument from ConfigList::updateList()
    Date
    This function allocates 'item' before using it, so the argument 'item'
    is always shadowed.

    Remove the meaningless argument.

    Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
    ---

    (no changes since v1)

    scripts/kconfig/qconf.cc | 6 +++---
    scripts/kconfig/qconf.h | 4 ++--
    2 files changed, 5 insertions(+), 5 deletions(-)

    diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
    index 0b93db2d61aa..8455f81e101f 100644
    --- a/scripts/kconfig/qconf.cc
    +++ b/scripts/kconfig/qconf.cc
    @@ -404,15 +404,15 @@ void ConfigList::updateSelection(void)
    emit menuSelected(menu);
    }

    -void ConfigList::updateList(ConfigItem* item)
    +void ConfigList::updateList()
    {
    ConfigItem* last = 0;
    + ConfigItem *item;

    if (!rootEntry) {
    if (mode != listMode)
    goto update;
    QTreeWidgetItemIterator it(this);
    - ConfigItem* item;

    while (*it) {
    item = (ConfigItem*)(*it);
    @@ -989,7 +989,7 @@ void ConfigView::updateList(ConfigItem* item)
    ConfigView* v;

    for (v = viewList; v; v = v->nextView)
    - v->list->updateList(item);
    + v->list->updateList();
    }

    void ConfigView::updateListAll(void)
    diff --git a/scripts/kconfig/qconf.h b/scripts/kconfig/qconf.h
    index 335f0776984f..4dc5d34a6bca 100644
    --- a/scripts/kconfig/qconf.h
    +++ b/scripts/kconfig/qconf.h
    @@ -69,7 +69,7 @@ class ConfigList : public QTreeWidget {
    public slots:
    void setRootMenu(struct menu *menu);

    - void updateList(ConfigItem *item);
    + void updateList();
    void setValue(ConfigItem* item, tristate val);
    void changeValue(ConfigItem* item);
    void updateSelection(void);
    @@ -85,7 +85,7 @@ public slots:
    void updateListAll(void)
    {
    updateAll = true;
    - updateList(NULL);
    + updateList();
    updateAll = false;
    }
    void addColumn(colIdx idx)
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-08-07 11:21    [W:3.276 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site