lkml.org 
[lkml]   [2020]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 10/11] bus: mhi: core: Introduce APIs to allocate and free the MHI controller
    On Mon, Jul 27, 2020 at 07:02:19PM -0700, Bhaumik Bhatt wrote:
    > Client devices should use the APIs provided to allocate and free
    > the MHI controller structure. This will help ensure that the
    > structure is zero-initialized and there are no false positives
    > with respect to reading any values such as the serial number or
    > the OEM PK hash.
    >
    > Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>

    Can you please also add the Suggested-by tag?

    Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

    Thanks,
    Mani

    > ---
    > drivers/bus/mhi/core/init.c | 16 ++++++++++++++++
    > include/linux/mhi.h | 12 ++++++++++++
    > 2 files changed, 28 insertions(+)
    >
    > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
    > index d2c0f6e..972dbf0 100644
    > --- a/drivers/bus/mhi/core/init.c
    > +++ b/drivers/bus/mhi/core/init.c
    > @@ -959,6 +959,22 @@ void mhi_unregister_controller(struct mhi_controller *mhi_cntrl)
    > }
    > EXPORT_SYMBOL_GPL(mhi_unregister_controller);
    >
    > +struct mhi_controller *mhi_alloc_controller(void)
    > +{
    > + struct mhi_controller *mhi_cntrl;
    > +
    > + mhi_cntrl = kzalloc(sizeof(*mhi_cntrl), GFP_KERNEL);
    > +
    > + return mhi_cntrl;
    > +}
    > +EXPORT_SYMBOL_GPL(mhi_alloc_controller);
    > +
    > +void mhi_free_controller(struct mhi_controller *mhi_cntrl)
    > +{
    > + kfree(mhi_cntrl);
    > +}
    > +EXPORT_SYMBOL_GPL(mhi_free_controller);
    > +
    > int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
    > {
    > struct device *dev = &mhi_cntrl->mhi_dev->dev;
    > diff --git a/include/linux/mhi.h b/include/linux/mhi.h
    > index d15e9ce..a35d876 100644
    > --- a/include/linux/mhi.h
    > +++ b/include/linux/mhi.h
    > @@ -530,6 +530,18 @@ struct mhi_driver {
    > #define to_mhi_device(dev) container_of(dev, struct mhi_device, dev)
    >
    > /**
    > + * mhi_alloc_controller - Allocate the MHI Controller structure
    > + * Allocate the mhi_controller structure using zero initialized memory
    > + */
    > +struct mhi_controller *mhi_alloc_controller(void);
    > +
    > +/**
    > + * mhi_free_controller - Free the MHI Controller structure
    > + * Free the mhi_controller structure which was previously allocated
    > + */
    > +void mhi_free_controller(struct mhi_controller *mhi_cntrl);
    > +
    > +/**
    > * mhi_register_controller - Register MHI controller
    > * @mhi_cntrl: MHI controller to register
    > * @config: Configuration to use for the controller
    > --
    > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
    > a Linux Foundation Collaborative Project
    >

    \
     
     \ /
      Last update: 2020-08-07 07:16    [W:7.604 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site