Messages in this thread | | | Subject | Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks | From | Jason Wang <> | Date | Fri, 7 Aug 2020 11:59:29 +0800 |
| |
On 2020/8/7 上午11:37, Jason Wang wrote: > > On 2020/8/7 上午3:18, Alex Dewar wrote: >> In alloc_inout() in net/mlx5_vnet.c, there are a few places where memory >> is allocated to *in and *out, but only the values of in and out are >> null-checked (i.e. there is a missing dereference). Fix this. >> >> Addresses-Coverity: ("CID 1496603: (REVERSE_INULL)") >> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 >> devices") >> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> > > > Acked-by: Jason Wang <jasowang@redhat.com>
Colin posted something similar: [PATCH][next] vdpa/mlx5: fix memory allocation failure checks
And I think his fix is better since it prevent raw pointers to be freed.
Thanks
| |