lkml.org 
[lkml]   [2020]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup_object()
Xin He <hexin.op@bytedance.com> 于2020年7月22日周三 下午1:19写道:
>
> Before setting shmem->pages to NULL, kfree() should
> be called.
>
> Signed-off-by: Xin He <hexin.op@bytedance.com>
> Reviewed-by: Qi Liu <liuqi.16@bytedance.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_object.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c
> index 6ccbd01cd888..703b5cd51751 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_object.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_object.c
> @@ -79,6 +79,7 @@ void virtio_gpu_cleanup_object(struct virtio_gpu_object *bo)
> }
>
> sg_free_table(shmem->pages);
> + kfree(shmem->pages);
> shmem->pages = NULL;
> drm_gem_shmem_unpin(&bo->base.base);
> }
> --
> 2.21.1 (Apple Git-122.3)
>

Ping guys. Any comments or suggestions?

--
Xin He

\
 
 \ /
  Last update: 2020-08-05 14:54    [W:0.061 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site