lkml.org 
[lkml]   [2020]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/18] spi: stm32-spi: defer probe for reset
On Wed, Aug 05, 2020 at 09:01:57AM +0200, Alain Volmat wrote:

> - rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> - if (!IS_ERR(rst)) {
> + rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL);
> + if (rst) {
> + if (IS_ERR(rst)) {
> + ret = PTR_ERR(rst);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "reset get failed: %d\n",
> + ret);
> + goto err_clk_disable;
> + }

This will not provide any diagnostics when deferring which isn't very
helpful if there's issues.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-08-05 13:15    [W:0.171 / U:1.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site