Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | paulmck@kernel ... | Subject | [PATCH tip/core/rcu 14/19] scftorture: Make symbol 'scf_torture_rand' static | Date | Mon, 31 Aug 2020 11:07:44 -0700 |
| |
From: Wei Yongjun <weiyongjun1@huawei.com>
The sparse tool complains as follows
kernel/scftorture.c:124:1: warning: symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static?
And this per-CPU variable is not used outside of scftorture.c, so this commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Paul E. McKenney <paulmck@kernel.org> --- kernel/scftorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/scftorture.c b/kernel/scftorture.c index 8349681..9180de7 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -134,7 +134,7 @@ static atomic_t n_alloc_errs; static bool scfdone; static char *bangstr = ""; -DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand); +static DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand); // Print torture statistics. Caller must ensure serialization. static void scf_torture_stats_print(void) -- 2.9.5
| ![\](/images/icornerr.gif) |