lkml.org 
[lkml]   [2020]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.8 33/42] drm/amd/display: should check error using DC_OK
    Date
    From: Tong Zhang <ztong0001@gmail.com>

    [ Upstream commit ed9ab229fea24cbcab17f484297dc8344afb7ea9 ]

    core_link_read_dpcd returns only DC_OK(1) and DC_ERROR_UNEXPECTED(-1),
    the caller should check error using DC_OK instead of checking against 0

    Signed-off-by: Tong Zhang <ztong0001@gmail.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
    index 91cd884d6f257..7728fd71d1f3a 100644
    --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
    +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
    @@ -4346,9 +4346,9 @@ bool dc_link_get_backlight_level_nits(struct dc_link *link,
    link->connector_signal != SIGNAL_TYPE_DISPLAY_PORT))
    return false;

    - if (!core_link_read_dpcd(link, DP_SOURCE_BACKLIGHT_CURRENT_PEAK,
    + if (core_link_read_dpcd(link, DP_SOURCE_BACKLIGHT_CURRENT_PEAK,
    dpcd_backlight_get.raw,
    - sizeof(union dpcd_source_backlight_get)))
    + sizeof(union dpcd_source_backlight_get)) != DC_OK)
    return false;

    *backlight_millinits_avg =
    @@ -4387,9 +4387,9 @@ bool dc_link_read_default_bl_aux(struct dc_link *link, uint32_t *backlight_milli
    link->connector_signal != SIGNAL_TYPE_DISPLAY_PORT))
    return false;

    - if (!core_link_read_dpcd(link, DP_SOURCE_BACKLIGHT_LEVEL,
    + if (core_link_read_dpcd(link, DP_SOURCE_BACKLIGHT_LEVEL,
    (uint8_t *) backlight_millinits,
    - sizeof(uint32_t)))
    + sizeof(uint32_t)) != DC_OK)
    return false;

    return true;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-08-31 17:37    [W:4.071 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site