lkml.org 
[lkml]   [2020]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFT 3/4] ARM: dts: exynos: Move CMU assigned ISP clocks to buses in Exynos3250
    On Mon, Aug 31, 2020 at 10:19:06AM +0200, Krzysztof Kozlowski wrote:
    > On Mon, Aug 31, 2020 at 10:11:02AM +0200, Marek Szyprowski wrote:
    > > Hi Krzysztof,
    > >
    > > On 29.08.2020 19:25, Krzysztof Kozlowski wrote:
    > > > Commit 52005dece527 ("ARM: dts: Add assigned clock parents to CMU node
    > > > for exynos3250") added assigned clocks under Clock Management Unit to
    > > > fix hangs when accessing ISP registers.
    > > >
    > > > This is not the place for it as CMU does not have a required "clocks"
    > > > property:
    > > >
    > > > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
    > > >
    > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    > > >
    > > > ---
    > > >
    > > > Not tested and I wonder whether actually correct. For example, what will
    > > > happen if devfreq (exynos-bus) is not built in?
    > > >
    > > > Could someone verify it?
    > >
    > > Sorry, but this patch is not correct. Those clocks has noting with
    > > bus-freq. The assigned clocks property should stay where it is. Maybe
    > > one need to fix the schemas for dts verification. Those clocks has to be
    > > set (and so generic clock framework does) according to the assigned
    > > clocks properties once the clock controller is instantiated.
    > >
    > > The only alternative would be to add exynos-subcmu variant to properly
    > > link CMU with the ISP power domain, but assuming that there is no Exynos
    > > 3250 ISP driver in mainline (and probably never will be), it is safe to
    > > keep those clocks sourced from 24MHz crystal.
    >
    > Thanks for the clarification. Another solution to silence the warning
    > could be to add a "clocks" property for FIN_PLL, although the driver
    > actually does not take it.
    >
    > This is the only remaining dtschema check warning on Exynos3250 so it
    > would be nice to at least silence it. My goal is to have all them
    > schema-correct, or as close as possible (for Exynos4 the camera node is
    > a trouble).

    BTW, if you have some time, it would be awesome if you could test all
    the series (on Exynos3250 obviously with this patch reverted):
    https://github.com/krzk/linux/tree/for-next/dts-exynos-schema-cleanups

    The Exynos5 cleanup is ongoing, so there will be more patches. But
    Exynos3 and Exynos4 I finished.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2020-08-31 10:32    [W:3.979 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site