Messages in this thread | | | Date | Mon, 31 Aug 2020 10:09:08 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 3/3] ARM: tegra: Pass multiple versions in opp-supported-hw property |
| |
On 28-08-20, 10:37, Dmitry Osipenko wrote: > 26.08.2020 14:50, Viresh Kumar пишет: > > We can now pass multiple versions in "opp-supported-hw" property, lets > > do that and simplify the tables a bit. > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > > > --- > > Dmitry, I think there is further scope of simplifying stuff here by > > using the opp-microvolt-<name> property and corresponding > > dev_pm_opp_set_prop_name() call.
Any inputs on this Dmitry ?
> > diff --git a/arch/arm/boot/dts/tegra30-cpu-opp.dtsi b/arch/arm/boot/dts/tegra30-cpu-opp.dtsi > ... > > - opp@1000000000,975,3,7 { > > - clock-latency-ns = <100000>; > > - opp-supported-hw = <0x08 0x0080>; > > - opp-hz = /bits/ 64 <1000000000>; > > + opp-supported-hw = <0x0F 0x0001>, > > + <0x01 0x0002>, > > + <0x01 0x0010>, > > + <0x01 0x0080>, > > + <0x01 0x0100>; > > + opp-hz = /bits/ 64 <475000000>; > > }; > > The only very minor difference between my OPP-gen result and yours is > that the above hunk has inconsistent single-column formatting, while all > others are two-column.
Ah, my mistake. Fixed and pushed now.
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com> > Tested-by: Dmitry Osipenko <digetx@gmail.com>
Thanks.
-- viresh
| |