Messages in this thread | | | From | Linus Walleij <> | Date | Sun, 30 Aug 2020 12:07:17 +0200 | Subject | Re: [PATCH] clk: versatile: Add of_node_put() before return statement |
| |
On Sat, Aug 29, 2020 at 7:57 PM Sumera Priyadarsini <sylphrenadin@gmail.com> wrote:
> Every iteration of for_each_available_child_of_node() decrements > the reference count of the previous node, however when control is > transferred from the middle of the loop, as in the case of a return > or break or goto, there is no decrement thus ultimately resulting in > a memory leak. > > Fix a potential memory leak in clk-impd1.c by inserting > of_node_put() before a return statement. > > Issue found with Coccinelle. > > Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |