lkml.org 
[lkml]   [2020]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC][PATCH] objtool,x86_64,paravirt: Add pv_ops[] support
On Mon, Aug 3, 2020 at 7:33 AM <peterz@infradead.org> wrote:
>
>
> Thomas wanted paramuck vs noinstr, here goes. Very rough, very nasty,
> mostly works.
>
> It requires call sites are the normal indirect call, and not mangled
> retpoison (slow_down_io() had those), it also requires pv_ops[]
> assignments are single instructions and not laundered through some
> pointless intermediate helper (hyperv).
>
> It doesn't warn when you get any of that wrong.
>
> But if you have it all lined up right, it will warn about noinstr
> violations due to paramuck:

I certainly agree that pv_ops is mucky, but could you expound on
precisely what this patch actually does? On a very quick
read-through, I'm guessing you're complaining about any call to pv_ops
in a noinstr section? But maybe this is only calls to pv_ops that
aren't themselves noinstr?

\
 
 \ /
  Last update: 2020-08-03 17:16    [W:0.039 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site