Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 3 Aug 2020 17:07:56 +0200 | From | Greg KH <> | Subject | Re: [PATCH v3] sched: Provide USF for the portable equipment. |
| |
On Mon, Aug 03, 2020 at 10:31:15PM +0800, Dongdong Yang wrote: > + /* > + * create a sched_usf in cpu_subsys: > + * /sys/devices/system/cpu/sched_usf/...
I thought I asked you not to use a "raw" kobject, you are making this much harder than it has to be.
Just use a normal struct device.
Also you failed to document your new sysfs files in Documentation/ABI/ like is required :(
Because of both of those things, this isn't ok as-is, sorry.
greg k-h
| ![\](/images/icornerr.gif) |