Messages in this thread | | | From | Daniel Gutson <> | Date | Mon, 3 Aug 2020 09:58:23 -0300 | Subject | Re: [PATCH] Module argument to control whether intel-spi-pci attempts to turn the SPI flash chip writeable |
| |
On Mon, Aug 3, 2020 at 7:27 AM Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > > On Mon, Aug 03, 2020 at 11:18:12AM +0100, Richard Hughes wrote: > > On Mon, 3 Aug 2020 at 10:57, Mika Westerberg > > <mika.westerberg@linux.intel.com> wrote: > > > I think instead of this we should simply make it so that the driver > > > never tries to make the chip writable. > > > > I think this is a good idea, but I wasn't sure if it was an acceptable > > behaviour change. Should the driver still try to set BCR_WPD when > > writing an image (i.e. defer the setting of write enable until later), > > or just not set the BCR register at all? I think your last comment was > > the latter, but wanted to check. > > I would say not set it at all. I think it was (my) mistake to set it in > the first place.
Do you want me to remove the module parameter from intel-spi too and do the same?
-- Daniel Gutson Argentina Site Director Enginieering Director Eclypsium
Below The Surface: Get the latest threat research and insights on firmware and supply chain threats from the research team at Eclypsium. https://eclypsium.com/research/#threatreport
| |