Messages in this thread | | | Date | Mon, 3 Aug 2020 10:41:28 +0200 | From | Tobias Klauser <> | Subject | Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump() |
| |
On 2020-08-02 at 13:15:40 +0200, Tianjia Zhang <tianjia.zhang@linux.alibaba.com> wrote: > In case of btf_id does not exist, a negative error code -ENOENT > should be returned. > > Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") > Cc: Andrii Nakryiko <andriin@fb.com> > Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
> --- > tools/bpf/bpftool/btf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c > index faac8189b285..c2f1fd414820 100644 > --- a/tools/bpf/bpftool/btf.c > +++ b/tools/bpf/bpftool/btf.c > @@ -596,7 +596,7 @@ static int do_dump(int argc, char **argv) > goto done; > } > if (!btf) { > - err = ENOENT; > + err = -ENOENT; > p_err("can't find btf with ID (%u)", btf_id); > goto done; > } > -- > 2.26.2 >
| |