Messages in this thread | | | From | Lai Jiangshan <> | Date | Mon, 3 Aug 2020 15:48:45 +0800 | Subject | Re: [PATCH] workqueue: Use wake_up_worker() to wake up first idle worker |
| |
On Mon, Jul 27, 2020 at 8:27 PM linmiaohe <linmiaohe@huawei.com> wrote: > > From: Miaohe Lin <linmiaohe@huawei.com> > > Use wrapper function wake_up_worker() to wake up first idle worker. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>
> --- > kernel/workqueue.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index c41c3c17b86a..5302f227f38f 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -864,7 +864,7 @@ void wq_worker_running(struct task_struct *task) > */ > void wq_worker_sleeping(struct task_struct *task) > { > - struct worker *next, *worker = kthread_data(task); > + struct worker *worker = kthread_data(task); > struct worker_pool *pool; > > /* > @@ -896,11 +896,9 @@ void wq_worker_sleeping(struct task_struct *task) > * lock is safe. > */ > if (atomic_dec_and_test(&pool->nr_running) && > - !list_empty(&pool->worklist)) { > - next = first_idle_worker(pool); > - if (next) > - wake_up_process(next->task); > - } > + !list_empty(&pool->worklist)) > + wake_up_worker(pool); > + > raw_spin_unlock_irq(&pool->lock); > } > > -- > 2.19.1 >
| |