lkml.org 
[lkml]   [2020]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] of: unittest: Use bigger address cells to catch parser regressions
On Mon, Aug 3, 2020 at 8:25 AM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> Getting address and size cells for dma-ranges/ranges parsing is tricky
> and shouldn't rely on the node's count_cells() method. The function
> starts looking for cells on the parent node, as its supposed to work
> with device nodes, which doesn't work when input with bus nodes, as
> generally done when parsing ranges.
>
> Add test to catch regressions on that specific quirk as developers will
> be tempted to edit it out in favor of the default method.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/of/unittest-data/tests-address.dtsi | 10 +++++-----
> drivers/of/unittest.c | 2 +-
> 2 files changed, 6 insertions(+), 6 deletions(-)

Applied, thanks.

Rob

\
 
 \ /
  Last update: 2020-08-04 00:28    [W:1.711 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site