Messages in this thread | ![/](/images/icornerl.gif) | | From | Rob Herring <> | Date | Mon, 3 Aug 2020 16:27:39 -0600 | Subject | Re: [PATCH] of: unittest: Use bigger address cells to catch parser regressions |
| |
On Mon, Aug 3, 2020 at 8:25 AM Nicolas Saenz Julienne <nsaenzjulienne@suse.de> wrote: > > Getting address and size cells for dma-ranges/ranges parsing is tricky > and shouldn't rely on the node's count_cells() method. The function > starts looking for cells on the parent node, as its supposed to work > with device nodes, which doesn't work when input with bus nodes, as > generally done when parsing ranges. > > Add test to catch regressions on that specific quirk as developers will > be tempted to edit it out in favor of the default method. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > --- > drivers/of/unittest-data/tests-address.dtsi | 10 +++++----- > drivers/of/unittest.c | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
Rob
| ![\](/images/icornerr.gif) |