Messages in this thread | | | Date | Mon, 03 Aug 2020 14:58:43 -0700 (PDT) | Subject | Re: [PATCH v4 2/2] net: dsa: ocelot: Add support for QinQ Operation | From | David Miller <> |
| |
From: hongbo.wang@nxp.com Date: Thu, 30 Jul 2020 18:25:05 +0800
> + if (vlan->proto == ETH_P_8021AD) { > + ocelot->enable_qinq = true; > + ocelot_port->qinq_mode = true; > + } ... > + if (vlan->proto == ETH_P_8021AD) { > + ocelot->enable_qinq = false; > + ocelot_port->qinq_mode = false; > + } > +
I don't understand how this can work just by using a boolean to track the state.
This won't work properly if you are handling multiple QinQ VLAN entries.
Also, I need Andrew and Florian to review and ACK the DSA layer changes that add the protocol value to the device notifier block.
| |