lkml.org 
[lkml]   [2020]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 2/2] net: dsa: ocelot: Add support for QinQ Operation
From
From: hongbo.wang@nxp.com
Date: Thu, 30 Jul 2020 18:25:05 +0800

> + if (vlan->proto == ETH_P_8021AD) {
> + ocelot->enable_qinq = true;
> + ocelot_port->qinq_mode = true;
> + }
...
> + if (vlan->proto == ETH_P_8021AD) {
> + ocelot->enable_qinq = false;
> + ocelot_port->qinq_mode = false;
> + }
> +

I don't understand how this can work just by using a boolean to track
the state.

This won't work properly if you are handling multiple QinQ VLAN entries.

Also, I need Andrew and Florian to review and ACK the DSA layer changes
that add the protocol value to the device notifier block.

\
 
 \ /
  Last update: 2020-08-03 23:59    [W:0.253 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site