Messages in this thread | | | Date | Mon, 3 Aug 2020 22:51:46 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v2 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip |
| |
On Mon 2020-08-03 19:42:17, Andy Shevchenko wrote: > On Mon, Aug 3, 2020 at 5:51 PM Eddie James <eajames@linux.ibm.com> wrote: > > > > IBM created an implementation of the PCA9552 on a PIC16F > > microcontroller. The I2C device addresses are different from the > > hardware PCA9552, so add a new compatible string and associated > > platform data to be able to probe this device. > > ... > > > pca9550, > > pca9551, > > pca9552, > > + ibm_pca9552, > > pca9553, > > I would rather not mix like this, but use alpha order, for example. > It's better to read and see which devices are supported by vendor.
Actually I see no huge reason to change that. pca9552 and ibm_pca9552 should be very similar, so it makes sense to keep them close together. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |