Messages in this thread | | | Date | Sat, 29 Aug 2020 22:26:09 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [RFC PATCH] coccinelle: misc: add uninitialized_var.cocci script |
| |
On Sat, 29 Aug 2020, Denis Efremov wrote:
> > > On 8/29/20 10:48 PM, Julia Lawall wrote: > > > > > > On Sat, 29 Aug 2020, Joe Perches wrote: > > > >> On Sat, 2020-08-29 at 21:36 +0200, Julia Lawall wrote: > >>> > >>> On Wed, 12 Aug 2020, Denis Efremov wrote: > >>> > >>>> Commit 63a0895d960a ("compiler: Remove uninitialized_var() macro") and > >>>> commit 4b19bec97c88 ("docs: deprecated.rst: Add uninitialized_var()") > >>>> removed uninitialized_var() and deprecated it. > >>>> > >>>> The purpose of this script is to prevent new occurrences of open-coded > >>>> variants of uninitialized_var(). > >> > >>>> Cc: Kees Cook <keescook@chromium.org> > >>>> Cc: Gustavo A. R. Silva <gustavoars@kernel.org> > >>>> Signed-off-by: Denis Efremov <efremov@linux.com> > >>> > >>> Applied, without the commented out part. > >>> > >>> I only got three warnings, though. Perhaps the others have been fixed? > >> > >> uninitialized_var does not exist in -next > > Yes, and this rule checks for not introducing these initializations once again. > > i.e, checks for: > > int a = a; > > int a = *(&a); > > > > > OK, if it seems better, I can remove it. Out of the threee reported, one > > was a completely unnecessary initialization. > > > > I would like send v2 with better description and link to the documentation because it's > now available online: > https://www.kernel.org/doc/html/latest/process/deprecated.html#uninitialized-var
OK, thanks.
julia
| |