Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sat, 29 Aug 2020 22:04:09 +1000 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions |
| |
On Fri, Aug 28, 2020 at 08:53:36PM -0500, George Acosta wrote: > Hi Herbert, > I just noticed a small potential issue about the calling sequence of > pci_disable_device and dev_err. > Do you think it will be better to call dev_err before we call > pci_disable_device(pdev) , or the order here does not matter?
I don't think it matters.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| ![\](/images/icornerr.gif) |