lkml.org 
[lkml]   [2020]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] netfilter: nf_conntrack_sip: fix parsing error
    On Sat, Aug 15, 2020 at 12:50:30PM -0400, Tong Zhang wrote:
    > ct_sip_parse_numerical_param can only return 0 or 1, but the caller is
    > checking parsing error using < 0

    Is this are real issue in your setup or probably some static analysis
    tool is reporting?

    You are right that ct_sip_parse_numerical_param() never returns < 0,
    however, looking at:

    https://tools.ietf.org/html/rfc3261 see Page 161

    expires is optional, my understanding is that your patch is making
    this option mandatory.

    \
     
     \ /
      Last update: 2020-08-28 20:09    [W:5.238 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site