Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 28 Aug 2020 11:54:46 +0100 | From | Russell King - ARM Linux admin <> | Subject | Re: [PATCH net v2] net: dsa: mt7530: fix advertising unsupported 1000baseT_Half |
| |
On Fri, Aug 28, 2020 at 06:52:44PM +0800, Landen Chao wrote: > Remove 1000baseT_Half to advertise correct hardware capability in > phylink_validate() callback function. > > Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5") > Signed-off-by: Landen Chao <landen.chao@mediatek.com> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks.
> --- > v1->v2 > - fix the commit subject spilled into the commit message > --- > drivers/net/dsa/mt7530.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 8dcb8a49ab67..238417db26f9 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -1501,7 +1501,7 @@ static void mt7530_phylink_validate(struct dsa_switch *ds, int port, > phylink_set(mask, 100baseT_Full); > > if (state->interface != PHY_INTERFACE_MODE_MII) { > - phylink_set(mask, 1000baseT_Half); > + /* This switch only supports 1G full-duplex. */ > phylink_set(mask, 1000baseT_Full); > if (port == 5) > phylink_set(mask, 1000baseX_Full); > -- > 2.17.1 > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| ![\](/images/icornerr.gif) |