Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH 1/1] USB: PHY: JZ4770: Fix static checker warning. | Date | Thu, 27 Aug 2020 16:06:07 +0300 |
| |
周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> writes:
> The commit 2a6c0b82e651 ("USB: PHY: JZ4770: Add support for new > Ingenic SoCs.") introduced the initialization function for different > chips, but left the relevant code involved in the resetting process > in the original function, resulting in uninitialized variable calls. > > Fixes: 2a6c0b82e651 ("USB: PHY: JZ4770: Add support for new > Ingenic SoCs.").
These two lines here, they should be one line :-)
For the Fixes: line, you shouldn't worry about the 72-char limit. Also, when resending, don't add a blank line between Fixes and Signed-off-by and since this is a bug fix, it seems like Cc: stable is in order.
-- balbi [unhandled content-type:application/pgp-signature] | |