lkml.org 
[lkml]   [2020]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 22/23] rbd: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code
    Date
    Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT()
    may be realized through them, thus reducing code redundancy and
    facilitating problem analysis.

    Signed-off-by: Chunguang Xu <brookxu@tencent.com>
    ---
    drivers/block/rbd.c | 9 +--------
    1 file changed, 1 insertion(+), 8 deletions(-)

    diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
    index d9c0e7d..798b9ad 100644
    --- a/drivers/block/rbd.c
    +++ b/drivers/block/rbd.c
    @@ -617,14 +617,7 @@ void rbd_warn(struct rbd_device *rbd_dev, const char *fmt, ...)
    }

    #ifdef RBD_DEBUG
    -#define rbd_assert(expr) \
    - if (unlikely(!(expr))) { \
    - printk(KERN_ERR "\nAssertion failure in %s() " \
    - "at line %d:\n\n" \
    - "\trbd_assert(%s);\n\n", \
    - __func__, __LINE__, #expr); \
    - BUG(); \
    - }
    +#define rbd_assert(expr) ASSERT_FAIL(expr)
    #else /* !RBD_DEBUG */
    # define rbd_assert(expr) ((void) 0)
    #endif /* !RBD_DEBUG */
    --
    1.8.3.1
    \
     
     \ /
      Last update: 2020-08-27 12:15    [W:4.138 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site