lkml.org 
[lkml]   [2020]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mwifiex: Clean up some err and dbg messages
From
Date
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> The error message if 'pci_set_consistent_dma_mask()' fails is misleading.
> The function call uses 32 bits, but the error message reports 64.
>
> Moreover, according to the comment above 'dma_set_mask_and_coherent()'
> definition, such an error can never happen.
>
> So, simplify code, axe the misleading message and use
> 'dma_set_mask_and_coherent()' instead of 'dma_set_mask()' +
> 'dma_set_coherent_mask()'
>
> While at it, make some clean-up:
> - add # when reporting allocated length to be consistent between
> functions
> - s/consistent/coherent/
> - s/unsigned int/u32/ to be consistent between functions
> - align some code
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Patch applied to wireless-drivers-next.git, thanks.

5f8a3ed38bec mwifiex: Clean up some err and dbg messages

--
https://patchwork.kernel.org/patch/11723131/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2020-08-27 12:00    [W:0.034 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site