lkml.org 
[lkml]   [2020]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 17/19] z2ram: reindent
From
Date
On Fri, 2020-08-28 at 09:21 +1000, Finn Thain wrote:
> > @@ -109,34 +111,28 @@ static void get_z2ram(void)
> ...
> > }
> > -
> > - return;
> > }
> >
>
> It would be good to have a semantic patch for that change.
>
> >
> > - if (z2ram_map[z2ram_size] == 0) {
> > + if (z2ram_map[z2ram_size] == 0)
> > break;
> > - }
> >
>
> And that one.
>
> Reason being, a semantic patch only has to be debugged once, whereas
> manual churn has to be done correctly over and over again.

checkpatch already does this.


\
 
 \ /
  Last update: 2020-08-28 02:02    [W:0.043 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site