Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 28 Aug 2020 00:55:09 +0200 | Subject | Re: [PATCH] gpio: siox: indicate exclusive support of threaded IRQs |
| |
Hi Ahmad,
On Tue, Aug 4, 2020 at 11:18 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> Generic GPIO consumers like gpio-keys use request_any_context_irq() > to request a threaded handler if irq_settings_is_nested_thread() == > true or a hardirq handler otherwise. > > Drivers using handle_nested_irq() must be sure that the nested > IRQs were requested with threaded handlers, because the IRQ > is handled by calling action->thread_fn(). > > The gpio-siox driver dispatches IRQs via handle_nested_irq, > but has irq_settings_is_nested_thread() == false. > > Set gpio_irq_chip::threaded to remedy this. > > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
I think we concluded we want to apply this patch, but with a fixed commit text, can you send a V2? (Or ask Uwe if he wants to pick it up and write the text.)
Yours, Linus Walleij
| |