Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [EXTERNAL] Re: [PATCH v1 1/2] dt-bindings: power: Add the bq256xx dt bindings | From | Ricardo Rivera-Matos <> | Date | Thu, 27 Aug 2020 16:07:45 -0500 |
| |
Rob
On 8/18/20 11:43 AM, Rob Herring wrote: > On Mon, Aug 17, 2020 at 02:17:22PM -0500, Ricardo Rivera-Matos wrote: >> Add the bindings for the bq256xx series of battery charging ICs. >> >> Datasheets: >> - https://www.ti.com/lit/ds/symlink/bq25600.pdf >> - https://www.ti.com/lit/ds/symlink/bq25601.pdf >> - https://www.ti.com/lit/ds/symlink/bq25600d.pdf >> - https://www.ti.com/lit/ds/symlink/bq25601d.pdf >> - https://www.ti.com/lit/ds/symlink/bq25611d.pdf >> - https://www.ti.com/lit/ds/symlink/bq25618.pdf >> - https://www.ti.com/lit/ds/symlink/bq25619.pdf >> >> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com> >> --- >> .../bindings/power/supply/bq256xx.yaml | 99 +++++++++++++++++++ >> 1 file changed, 99 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/supply/bq256xx.yaml >> >> diff --git a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml >> new file mode 100644 >> index 000000000000..67db4ba9fdb6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml >> @@ -0,0 +1,99 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> +# Copyright (C) 2020 Texas Instruments Incorporated >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/power/supply/bq256xx.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: TI bq256xx Switch Mode Buck Charger >> + >> +maintainers: >> + - Ricardo Rivera-Matos <r-rivera-matos@ti.com> >> + >> +description: | >> + The bq256xx devices are a family of highly-integrated battery charge >> + management and system power management ICs for single cell Li-ion and Li- >> + polymer batteries. >> + >> + Datasheets: >> + - https://www.ti.com/lit/ds/symlink/bq25600.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25601.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25600d.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25601d.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25611d.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25618.pdf >> + - https://www.ti.com/lit/ds/symlink/bq25619.pdf >> + >> +properties: >> + compatible: >> + enum: >> + - ti,bq25600 >> + - ti,bq25601 >> + - ti,bq25600d >> + - ti,bq25601d >> + - ti,bq25611d >> + - ti,bq25618 >> + - ti,bq25619 >> + >> + reg: >> + maxItems: 1 >> + >> + ti,watchdog-timer: > Poorly named since we have 'ti,watchdog-timers' already and is > completely different. ACK, will use ti,watchdog-timeout-ms instead > >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: | >> + Watchdog timer in milli seconds. 0 (default) disables the watchdog > If you have units, then you should use standard unit suffix. ACK > >> + minimum: 0 >> + maximum: 160000 >> + enum: [ 0, 40000, 80000, 160000] >> + >> + input-voltage-limit-microvolt: >> + description: | >> + Minimum input voltage limit in micro volts with a 100000 micro volt step >> + minimum: 3900000 >> + maximum: 5400000 >> + >> + input-current-limit-microamp: >> + description: | >> + Maximum input current limit in micro amps with a 100000 micro amp step >> + minimum: 100000 >> + maximum: 3200000 > Aren't these properties of the battery, not the charger? These are input current and voltage limit for the charger, not the battery > >> + >> +required: >> + - compatible >> + - reg > monitored-battery not required? ACK > > Add: > > additionalProperties: false additionalProperties: false or unevaluatedProperties: false > > >> + >> +examples: >> + - | >> + bat: battery { >> + compatible = "simple-battery"; >> + constant-charge-current-max-microamp = <2040000>; >> + constant-charge-voltage-max-microvolt = <4352000>; >> + precharge-current-microamp = <180000>; >> + termination-current-microamp = <180000>; >> + }; >> + #include <dt-bindings/gpio/gpio.h> >> + #include <dt-bindings/interrupt-controller/irq.h> >> + i2c0 { > i2c { ACK > >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c2_pins>; > Not relevant to the example. ACK > >> + >> + status = "okay"; > Don't show status in examples. ACK > >> + clock-frequency = <400000>; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + bq25601@6b { > charger@6b ACK > >> + compatible = "ti,bq25601"; >> + reg = <0x6b>; >> + monitored-battery = <&bat>; >> + >> + interrupt-parent = <&gpio1>; >> + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; >> + watchdog-timer = <40000>; >> + >> + input-voltage-limit-microvolt = <4500000>; >> + input-current-limit-microamp = <2400000>; >> + }; >> + }; >> +... >> -- >> 2.28.0 >> Ricardo
| ![\](/images/icornerr.gif) |