Messages in this thread | | | Date | Thu, 27 Aug 2020 09:12:27 +0200 | From | Stefano Garzarella <> | Subject | Re: [PATCH v4 2/3] io_uring: add IOURING_REGISTER_RESTRICTIONS opcode |
| |
On Wed, Aug 26, 2020 at 12:46:24PM -0700, Kees Cook wrote: > On Thu, Aug 13, 2020 at 05:32:53PM +0200, Stefano Garzarella wrote: > > +/* > > + * io_uring_restriction->opcode values > > + */ > > +enum { > > + /* Allow an io_uring_register(2) opcode */ > > + IORING_RESTRICTION_REGISTER_OP, > > + > > + /* Allow an sqe opcode */ > > + IORING_RESTRICTION_SQE_OP, > > + > > + /* Allow sqe flags */ > > + IORING_RESTRICTION_SQE_FLAGS_ALLOWED, > > + > > + /* Require sqe flags (these flags must be set on each submission) */ > > + IORING_RESTRICTION_SQE_FLAGS_REQUIRED, > > + > > + IORING_RESTRICTION_LAST > > +}; > > Same thought on enum literals, but otherwise, looks good:
Sure, I'll fix the enum in the next version.
> > Reviewed-by: Kees Cook <keescook@chromium.org>
Thanks for the review, Stefano
| |