Messages in this thread | | | Subject | Re: [PATCH v2 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value() | From | Tom Rix <> | Date | Thu, 27 Aug 2020 12:04:23 -0700 |
| |
On 8/27/20 7:32 AM, Luca Ceresoli wrote: > Current code calls gpiod_get_value() without error checking. Should the > GPIO controller fail, execution would continue without any error message. > > Fix by checking for negative error values. > > Reported-by: Tom Rix <trix@redhat.com> > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > > ---
Thanks, this looks fine.
Reviewed-by: Tom Rix <trix@redhat.com>
| |