Messages in this thread | ![/](/images/icornerl.gif) | | From | Konstantin Komarov <> | Subject | RE: [PATCH v2 00/10] fs: NTFS read-write driver GPL implementation by Paragon Software. | Date | Thu, 27 Aug 2020 16:12:45 +0000 |
| |
From: Joe Perches <joe@perches.com> Sent: Friday, August 21, 2020 10:21 PM > > On Fri, 2020-08-21 at 16:24 +0000, Konstantin Komarov wrote: > > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Thanks. > Proper ntfs read/write support will be great addition. > > Trivia: > > If this patchset is submitted again with a new version, > please use something like "git format-patch --cover-letter" > and "git send-email" so all parts of the patches and replies > have the a single message thread to follow. > > That will add an "in-reply-to" header of the 0/m patch > message-id to all n/m parts. >
Hi Joe! Thanks a lot. Will use git send-email for V3. format-patch and --cover-letter have been already used for v2.
> One style oddity I noticed is the use of goto labels in > favor of if block indentation. It's not terrible style, > just unusual for kernel code. >
AFAIK goto's are being quite widely used in kernel code as well. However V3 will introduce several goto's replacements with if blocks.
Thanks!
| ![\](/images/icornerr.gif) |