Messages in this thread | | | Subject | Re: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM | From | Sameer Pujar <> | Date | Tue, 25 Aug 2020 11:23:11 +0530 |
| |
Hi Morimoto-san,
>>> Yes, I'm posting fixup patch. >>> >>> https://patchwork.kernel.org/patch/11719919/ >> Just curious that why snd_soc_find_dai() itself cannot be protected, >> instead of leaving this to callers. > Because, snd_soc_find_dai() is called both with/without client_mutex. > (same/sof are calling it with mutex, simple-card/audio-graph are calling without mutex) > > Other solution is create both snd_soc_find_dai_with_mutex()/without_mutex(). > I'm not sure which style is best.
I don't know how complex it is to have a unified solution. But if we can protect snd_soc_find_dai() itself, things would be simpler may be in long term. Right now there are separate source files for soc-core, soc-dai and soc-component, but because of two approaches looks like the function need to be moved around and need to be placed in soc-core. Also the issue might go unnoticed if LOCKDEP is not enabled.
May be start with a wrapper for now and eventually unify?
Thanks, Sameer.
| |