Messages in this thread | | | Date | Tue, 25 Aug 2020 19:09:55 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v2 1/7][next] printk: ringbuffer: rename DESC_COMMITTED_MASK flag |
| |
On Mon 2020-08-24 12:41:32, John Ogness wrote: > The flag DESC_COMMITTED_MASK has a much longer name compared to the > other state flags and also is in past tense form, rather than in > command form. Rename the flag to DESC_COMMIT_MASK in order to match > the other state flags.
I am not a native speaker. But the command form sounds a bit misleading to me.
I see that the new name will make more sense after adding the state "FINAL". But "FINAL" will not be a command form either.
I am fine with the change but I would prefer a better commit message. What about something like?
"A comming support for continuous lines will allow to reopen records with DESC_COMMITTED_MASK set. As a result, the flag will not longer describe the final committed state. Rename it to DESC_COMMIT_MASK as a preparation step."
With the updated commit message:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |