Messages in this thread | | | Subject | Re: [PATCH] IB/qib: remove superfluous fallthrough statements | From | Joe Perches <> | Date | Tue, 25 Aug 2020 09:47:50 -0700 |
| |
On Tue, 2020-08-25 at 11:49 -0500, Gustavo A. R. Silva wrote: > > On 8/25/20 11:26, Joe Perches wrote: > > On Tue, 2020-08-25 at 11:19 -0500, Gustavo A. R. Silva wrote: > > > On 8/25/20 10:51, Alex Dewar wrote: > > > > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > > > > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which > > > > were later converted to fallthrough statements by commit df561f6688fe > > > > ("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity > > > > warning about unreachable code. > > > > > > > > Remove the fallthrough statements and replace the mass of gotos with > > > > simple return statements to make the code terser and less bug-prone. > > > > > > > > > > This should be split up into two separate patches: one to address the > > > fallthrough markings, and another one for the gotos. > > > > I don't think it's necessary to break this into multiple patches. > > Logical changes in a single patch are just fine, micro patches > > aren't that useful. > > > > There is a reason for this. Read the changelog text and review the patch.
What makes you think I didn't already do that?
I think your desire for micropatches is unnecessary.
| |