Messages in this thread Patch in this message | | | Subject | Re: [PATCH] scsi: megaraid: Remove unnecessary assignment to variable ret | From | Joe Perches <> | Date | Tue, 25 Aug 2020 00:06:26 -0700 |
| |
On Tue, 2020-08-25 at 00:01 -0700, Joe Perches wrote: > On Tue, 2020-08-25 at 14:38 +0800, Jing Xiangfeng wrote: > > The variable ret is being initialized with 'FAILED'. So we can remove > > this assignement. > > If you are going to change the code at all, > might as well try to improve it more by removing > the unnecessary out: label altogether.
Looks like the megaraid mailing list is either subscribers-only or doesn't exist anymore as my mail to it bounced.
One of the maintainers should remove it or update it.
Maybe: --- diff --git a/MAINTAINERS b/MAINTAINERS index ac79fdbdf8d0..0c181cd07201 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11060,7 +11060,7 @@ MEGARAID SCSI/SAS DRIVERS M: Kashyap Desai <kashyap.desai@broadcom.com> M: Sumit Saxena <sumit.saxena@broadcom.com> M: Shivasharan S <shivasharan.srikanteshwara@broadcom.com> -L: megaraidlinux.pdl@broadcom.com +L: megaraidlinux.pdl@broadcom.com (subscribers-only) L: linux-scsi@vger.kernel.org S: Maintained W: http://www.avagotech.com/support/
| |