lkml.org 
[lkml]   [2020]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings
    On Tue, Aug 18, 2020 at 11:50:27AM +0800, Cheng-Yi Chiang wrote:
    > Add devicetree bindings documentation file for sc7180 sound card.
    >
    > Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
    > ---
    > .../bindings/sound/qcom,sc7180.yaml | 127 ++++++++++++++++++
    > 1 file changed, 127 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml
    > new file mode 100644
    > index 000000000000..b5cdaa0fe559
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml
    > @@ -0,0 +1,127 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/sound/qcom,sc7180.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver
    > +
    > +maintainers:
    > + - Rohit kumar <rohitkr@codeaurora.org>
    > + - Cheng-Yi Chiang <cychiang@chromium.org>
    > +
    > +description:
    > + This binding describes the SC7180 sound card which uses LPASS for audio.
    > +
    > +properties:
    > + compatible:
    > + contains:

    Drop contains. Should be exactly the string listed.

    > + const: qcom,sc7180-sndcard
    > +
    > + audio-routing:
    > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
    > + description:
    > + A list of the connections between audio components. Each entry is a
    > + pair of strings, the first being the connection's sink, the second
    > + being the connection's source.
    > +
    > + model:
    > + $ref: /schemas/types.yaml#/definitions/string
    > + description: User specified audio sound card name
    > +
    > + aux-dev:
    > + $ref: /schemas/types.yaml#/definitions/phandle
    > + description: phandle of the codec for headset detection
    > +
    > + "#address-cells":
    > + const: 1
    > +
    > + "#size-cells":
    > + const: 0
    > +
    > +patternProperties:
    > + "^dai-link(@[0-9]+)?$":

    Unit addresses are hex. Do you really have more than 10?

    > + description:
    > + Each subnode represents a dai link. Subnodes of each dai links would be
    > + cpu/codec dais.
    > +
    > + type: object
    > +
    > + properties:
    > + link-name:
    > + description: Indicates dai-link name and PCM stream name.
    > + $ref: /schemas/types.yaml#/definitions/string
    > + maxItems: 1
    > +
    > + reg:
    > + description: dai link address.
    > + $ref: /schemas/types.yaml#/definitions/uint32

    reg already has a type. Drop.

    > + maxItems: 1
    > +
    > + cpu:
    > + description: Holds subnode which indicates cpu dai.
    > + type: object
    > + properties:
    > + sound-dai: true
    > +
    > + codec:
    > + description: Holds subnode which indicates codec dai.
    > + type: object
    > + properties:
    > + sound-dai: true
    > +
    > + required:
    > + - link-name
    > + - cpu
    > + - codec
    > +
    > + additionalProperties: false
    > +
    > +required:
    > + - compatible
    > + - model
    > + - "#address-cells"
    > + - "#size-cells"
    > +
    > +additionalProperties: false
    > +
    > +examples:
    > +
    > + - |
    > + sound {
    > + compatible = "qcom,sc7180-sndcard";
    > + model = "sc7180-snd-card";
    > +
    > + audio-routing =
    > + "Headphone Jack", "HPOL",
    > + "Headphone Jack", "HPOR";
    > +
    > + aux-dev = <&alc5682>;
    > +
    > + #address-cells = <1>;
    > + #size-cells = <0>;
    > +
    > + dai-link@0 {
    > + link-name = "MultiMedia0";
    > + reg = <0>;
    > + cpu {
    > + sound-dai = <&lpass_cpu 0>;
    > + };
    > +
    > + codec {
    > + sound-dai = <&alc5682 0>;
    > + };
    > + };
    > +
    > + dai-link@1 {
    > + link-name = "MultiMedia1";
    > + reg = <1>;
    > + cpu {
    > + sound-dai = <&lpass_cpu 1>;
    > + };
    > +
    > + codec {
    > + sound-dai = <&max98357a>;
    > + };
    > + };
    > + };
    > --
    > 2.28.0.220.ged08abb693-goog
    >

    \
     
     \ /
      Last update: 2020-08-25 21:19    [W:5.722 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site