Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 24 Aug 2020 14:22:06 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v4 1/2] staging: android: Remove BUG_ON from ion_page_pool.c |
| |
On Fri, Aug 21, 2020 at 06:27:37PM +0300, Tomer Samara wrote: > BUG_ON() is removed at ion_page_pool.c > > Fixes the following issue: > Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). > > Signed-off-by: Tomer Samara <tomersamara98@gmail.com> > ---
You should put a note here about what changed between v3 vs v4. Like so: --- v4: Just remove the BUG_ON()s instead of adding new returns. v3: Hand the new return paths or whatever.
Anyway, looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| ![\](/images/icornerr.gif) |