lkml.org 
[lkml]   [2020]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 094/124] scsi: ufs: Add quirk to disallow reset of interrupt aggregation
    Date
    From: Alim Akhtar <alim.akhtar@samsung.com>

    [ Upstream commit b638b5eb624bd5d0766683b6181d578f414585e9 ]

    Some host controllers support interrupt aggregation but don't allow
    resetting counter and timer in software.

    Link: https://lore.kernel.org/r/20200528011658.71590-3-alim.akhtar@samsung.com
    Reviewed-by: Avri Altman <avri.altman@wdc.com>
    Signed-off-by: Seungwon Jeon <essuuj@gmail.com>
    Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/ufs/ufshcd.c | 3 ++-
    drivers/scsi/ufs/ufshcd.h | 6 ++++++
    2 files changed, 8 insertions(+), 1 deletion(-)

    diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
    index 9e31f9569bf78..acd8fb4981142 100644
    --- a/drivers/scsi/ufs/ufshcd.c
    +++ b/drivers/scsi/ufs/ufshcd.c
    @@ -4889,7 +4889,8 @@ static irqreturn_t ufshcd_transfer_req_compl(struct ufs_hba *hba)
    * false interrupt if device completes another request after resetting
    * aggregation and before reading the DB.
    */
    - if (ufshcd_is_intr_aggr_allowed(hba))
    + if (ufshcd_is_intr_aggr_allowed(hba) &&
    + !(hba->quirks & UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR))
    ufshcd_reset_intr_aggr(hba);

    tr_doorbell = ufshcd_readl(hba, REG_UTP_TRANSFER_REQ_DOOR_BELL);
    diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
    index ceadbd548e06d..5b1acdd83d5c1 100644
    --- a/drivers/scsi/ufs/ufshcd.h
    +++ b/drivers/scsi/ufs/ufshcd.h
    @@ -523,6 +523,12 @@ enum ufshcd_quirks {
    * Clear handling for transfer/task request list is just opposite.
    */
    UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR = 1 << 6,
    +
    + /*
    + * This quirk needs to be enabled if host controller doesn't allow
    + * that the interrupt aggregation timer and counter are reset by s/w.
    + */
    + UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR = 1 << 7,
    };

    enum ufshcd_caps {
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-24 11:45    [W:8.843 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site