lkml.org 
[lkml]   [2020]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 035/107] mm/memory.c: skip spurious TLB flush for retried page fault
    Date
    From: Yang Shi <shy828301@gmail.com>

    commit b7333b58f358f38d90d78e00c1ee5dec82df10ad upstream.

    Recently we found regression when running will_it_scale/page_fault3 test
    on ARM64. Over 70% down for the multi processes cases and over 20% down
    for the multi threads cases. It turns out the regression is caused by
    commit 89b15332af7c ("mm: drop mmap_sem before calling
    balance_dirty_pages() in write fault").

    The test mmaps a memory size file then write to the mapping, this would
    make all memory dirty and trigger dirty pages throttle, that upstream
    commit would release mmap_sem then retry the page fault. The retried
    page fault would see correct PTEs installed then just fall through to
    spurious TLB flush. The regression is caused by the excessive spurious
    TLB flush. It is fine on x86 since x86's spurious TLB flush is no-op.

    We could just skip the spurious TLB flush to mitigate the regression.

    Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
    Reported-by: Xu Yu <xuyu@linux.alibaba.com>
    Debugged-by: Xu Yu <xuyu@linux.alibaba.com>
    Tested-by: Xu Yu <xuyu@linux.alibaba.com>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: Will Deacon <will.deacon@arm.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Yang Shi <shy828301@gmail.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    mm/memory.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/mm/memory.c
    +++ b/mm/memory.c
    @@ -3886,6 +3886,9 @@ static vm_fault_t handle_pte_fault(struc
    vmf->flags & FAULT_FLAG_WRITE)) {
    update_mmu_cache(vmf->vma, vmf->address, vmf->pte);
    } else {
    + /* Skip spurious TLB flush for retried page fault */
    + if (vmf->flags & FAULT_FLAG_TRIED)
    + goto unlock;
    /*
    * This is needed only for protection faults but the arch code
    * is not yet telling us if this is a protection fault or not.

    \
     
     \ /
      Last update: 2020-08-24 10:47    [W:7.847 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site