lkml.org 
[lkml]   [2020]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v11 02/11] dt-bindings: PCI: Add bindings for more Brcmstb chips
    Date
    From: Jim Quinlan <jquinlan@broadcom.com>

    - Add compatible strings for three more Broadcom STB chips: 7278, 7216,
    7211 (STB version of RPi4).
    - Add new property 'brcm,scb-sizes'.
    - Add new property 'resets'.
    - Add new property 'reset-names' for 7216 only.
    - Allow 'ranges' and 'dma-ranges' to have more than one item and update
    the example to show this.

    Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
    Reviewed-by: Rob Herring <robh@kernel.org>
    ---
    .../bindings/pci/brcm,stb-pcie.yaml | 56 ++++++++++++++++---
    1 file changed, 49 insertions(+), 7 deletions(-)

    diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
    index 8680a0f86c5a..807694b4f41f 100644
    --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
    +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
    @@ -9,12 +9,15 @@ title: Brcmstb PCIe Host Controller Device Tree Bindings
    maintainers:
    - Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

    -allOf:
    - - $ref: /schemas/pci/pci-bus.yaml#
    -
    properties:
    compatible:
    - const: brcm,bcm2711-pcie # The Raspberry Pi 4
    + items:
    + - enum:
    + - brcm,bcm2711-pcie # The Raspberry Pi 4
    + - brcm,bcm7211-pcie # Broadcom STB version of RPi4
    + - brcm,bcm7278-pcie # Broadcom 7278 Arm
    + - brcm,bcm7216-pcie # Broadcom 7216 Arm
    + - brcm,bcm7445-pcie # Broadcom 7445 Arm

    reg:
    maxItems: 1
    @@ -34,10 +37,12 @@ properties:
    - const: msi

    ranges:
    - maxItems: 1
    + minItems: 1
    + maxItems: 4

    dma-ranges:
    - maxItems: 1
    + minItems: 1
    + maxItems: 6

    clocks:
    maxItems: 1
    @@ -58,8 +63,31 @@ properties:

    aspm-no-l0s: true

    + resets:
    + description: for "brcm,bcm7216-pcie", must be a valid reset
    + phandle pointing to the RESCAL reset controller provider node.
    + $ref: "/schemas/types.yaml#/definitions/phandle"
    +
    + reset-names:
    + items:
    + - const: rescal
    +
    + brcm,scb-sizes:
    + description: u64 giving the 64bit PCIe memory
    + viewport size of a memory controller. There may be up to
    + three controllers, and each size must be a power of two
    + with a size greater or equal to the amount of memory the
    + controller supports. Note that each memory controller
    + may have two component regions -- base and extended -- so
    + this information cannot be deduced from the dma-ranges.
    + $ref: /schemas/types.yaml#/definitions/uint64-array
    + items:
    + minItems: 1
    + maxItems: 3
    +
    required:
    - reg
    + - ranges
    - dma-ranges
    - "#interrupt-cells"
    - interrupts
    @@ -68,6 +96,18 @@ required:
    - interrupt-map
    - msi-controller

    +allOf:
    + - $ref: /schemas/pci/pci-bus.yaml#
    + - if:
    + properties:
    + compatible:
    + contains:
    + const: brcm,bcm7216-pcie
    + then:
    + required:
    + - resets
    + - reset-names
    +
    unevaluatedProperties: false

    examples:
    @@ -93,7 +133,9 @@ examples:
    msi-parent = <&pcie0>;
    msi-controller;
    ranges = <0x02000000 0x0 0xf8000000 0x6 0x00000000 0x0 0x04000000>;
    - dma-ranges = <0x02000000 0x0 0x00000000 0x0 0x00000000 0x0 0x80000000>;
    + dma-ranges = <0x42000000 0x1 0x00000000 0x0 0x40000000 0x0 0x80000000>,
    + <0x42000000 0x1 0x80000000 0x3 0x00000000 0x0 0x80000000>;
    brcm,enable-ssc;
    + brcm,scb-sizes = <0x0000000080000000 0x0000000080000000>;
    };
    };
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-08-24 21:31    [W:5.299 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site