Messages in this thread | | | From | Arnd Bergmann <> | Date | Mon, 24 Aug 2020 20:38:45 +0200 | Subject | Re: [PATCH v7 02/10] arm64: hyperv: Add core Hyper-V include files |
| |
On Mon, Aug 24, 2020 at 6:47 PM Michael Kelley <mikelley@microsoft.com> wrote: > + > +#define hv_get_simp(val) (val = hv_get_vpreg(HV_REGISTER_SIPP)) > + > +#define hv_get_siefp(val) (val = hv_get_vpreg(HV_REGISTER_SIFP))
Macros that modify their arguments are generally a bad idea. Since each one of these only has a few callers, could you just redefine the x86 version to use function-style calling conventions and turn them into inline functions?
Arnd
| |