lkml.org 
[lkml]   [2020]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 02/19] dlb2: initialize PF device
Date
> > +#include <linux/io.h>
> > +
> > +#define DLB2_PCI_REG_READ(addr) ioread32(addr)
> > +#define DLB2_PCI_REG_WRITE(reg, value) iowrite32(value, reg)
>
> Why create a macro that is larger than the native call, this saves
> nothing except make the reviewer wonder what in the world is happening.
>
> Just use the real call.

Sure, I'll change this in v3. I'll wait for more reviews before re-submitting.

Thanks,
Gage

\
 
 \ /
  Last update: 2020-08-24 18:52    [W:7.200 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site