Messages in this thread | | | Subject | Re: [PATCH] ntb: intel: Fix memleak in intel_ntb_pci_probe | From | Dave Jiang <> | Date | Mon, 24 Aug 2020 07:37:56 -0700 |
| |
On 8/22/2020 11:55 PM, Dinghao Liu wrote: > The default error branch of a series of pdev_is_gen calls > should free ndev just like what we've done in these calls. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Thanks Dinghao Acked-by: Dave Jiang <dave.jiang@intel.com>
> --- > drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ntb/hw/intel/ntb_hw_gen1.c b/drivers/ntb/hw/intel/ntb_hw_gen1.c > index 3185efeab487..093dd20057b9 100644 > --- a/drivers/ntb/hw/intel/ntb_hw_gen1.c > +++ b/drivers/ntb/hw/intel/ntb_hw_gen1.c > @@ -1893,7 +1893,7 @@ static int intel_ntb_pci_probe(struct pci_dev *pdev, > goto err_init_dev; > } else { > rc = -EINVAL; > - goto err_ndev; > + goto err_init_pci; > } > > ndev_reset_unsafe_flags(ndev); >
| |