Messages in this thread | | | Date | Mon, 24 Aug 2020 00:30:37 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v1 3/6] leds: Add driver for Acer Iconia Tab A500 |
| |
Hi!
> Acer Iconia Tab A500 is an Android tablet device which has two LEDs > embedded into the Power Button. Orange LED indicates "battery charging" > status and white LED indicates "wake-up/charge-done" status. The new LED > driver provides control over both LEDs to userspace.
> @@ -0,0 +1,121 @@ > +// SPDX-License-Identifier: GPL-2.0+
Nice.
> + * Copyright 2020 GRATE-driver project.
Probably untrue.
> + white_led->cdev.name = "power-button-white";
"white:power"
> + white_led->cdev.max_brightness = LED_ON;
= 1. (And you'll need other adjustments over the code).
> + orange_led->cdev.name = "power-button-orange";
"orange:power" -- or what is this LED usually used for?
> +MODULE_LICENSE("GPL v2");
Should be "GPL"? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |