Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sat, 22 Aug 2020 12:33:15 -0700 (PDT) | Subject | Re: [PATCH net-next] net: Remove unnecessary intermediate variables | From | David Miller <> |
| |
From: Jianlin Lv <Jianlin.Lv@arm.com> Date: Sat, 22 Aug 2020 10:04:31 +0800
> It is not necessary to use src/dst as an intermediate variable for > assignment operation; Delete src/dst intermediate variables to avoid > unnecessary variable declarations. > > Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
It keeps the line lengths within reasonable length, so these local variables are fine.
Also, the appropriate subsystem prefix for this patch should be "vxlan: " not "net: " in your Subject line. If someone is skimming the shortlog in 'git' how will they tell where exactly in the networking your change is being made?
Anyways, I'm not applying this, thanks.
| ![\](/images/icornerr.gif) |